vinothchandar opened a new pull request, #19284: URL: https://github.com/apache/hudi/pull/19284
### Describe the issue this Pull Request addresses Follow-ups from the `*Utils` consolidation sweep (#19212): small remaining duplications and a misleading naming inversion that were identified during that PR's review but deferred to keep it scoped. ### Summary and Changelog Behavior-preserving cleanup; no user-facing change: - **`SecondaryIndexKeyUtils`**: rename `getUnescapedSecondaryKey[Prefix]FromSecondaryIndexKey` → `getEscapedSecondaryKey[Prefix]FromSecondaryIndexKey`. Both methods return the still-encoded key segment (the caller that actually decodes applies `unescapeSpecialChars` on top), so the old names stated the opposite of the behavior; the new names match the existing `getEscapedSecondaryKeyPrefixFromSecondaryKey` convention. - **`HoodieHiveUtils#getNthParent`**: deleted — byte-identical to `TablePathUtils`' private walker. The latter is now public and the one remaining caller (`HoodieROTablePathFilter`) uses it. - **`CommonClientUtils#generateWriteToken`**: folded into `FSUtils` as a `makeWriteToken(TaskContextSupplier)` overload next to its 3-arg sibling; single caller (`RollbackHelperV1`) migrated. Also completed the review follow-up audit of all `HoodieAvroUtils#unwrapNullable` call sites for multi-member-union exposure: no reachable mis-resolution (variant-shredding sites use internally-constructed schemas; the one arbitrary-schema site, `projectFields`, discards the unwrapped result or validates RECORD and throws). Documented; no code change needed. ### Impact None on public APIs or user-facing behavior. Renamed methods are internal metadata-index utils; all callers and tests migrated. ### Risk Level Low. Verified with checkstyle/scalastyle gates enabled plus the affected test classes: `TestSecondaryIndexKeyUtils` (86 tests), `TestTablePathUtils`, `TestFSUtils`, `TestHoodieTableMetadataUtil` — all green. ### Documentation Update None. ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [x] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
