hudi-agent commented on code in PR #19285:
URL: https://github.com/apache/hudi/pull/19285#discussion_r3578541179
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java:
##########
@@ -118,15 +120,16 @@ public static ParquetMetadata
readFileMetadataOnly(HoodieStorage storage, Storag
private static ParquetMetadata readMetadata(HoodieStorage storage,
StoragePath parquetFilePath, ParquetMetadataConverter.MetadataFilter
metadataFilter) {
Path parquetFileHadoopPath = new Path(parquetFilePath.toUri());
- ParquetMetadata footer;
- try {
+ Configuration conf = storage.newInstance(
+ parquetFilePath,
storage.getConf()).getConf().unwrapAs(Configuration.class);
+ try (ParquetFileReader reader = ParquetFileReader.open(
Review Comment:
🤖 The recent `fix test failure` commit reverted `HoodieAvroParquetReader` to
the deprecated `readFooter` because Hive 2.3 MR tasks can load Parquet 1.8.x,
which lacks `ParquetFileReader.open(InputFile, ...)`. But
`HiveHoodieReaderContext.getFileRecordIterator` (same hudi-hadoop-mr module)
reaches this method via `getFileFormatUtils(path).readSchema(...)` →
`readMessageType` → `readMetadata`. Wouldn't the file-group-reader Hive path
then hit the same `NoSuchMethodError` this `open()` call reintroduces? It looks
like the shim only covers one of the two footer reads reachable from the Hive
runtime.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
