voonhous commented on PR #13748: URL: https://github.com/apache/hudi/pull/13748#issuecomment-4977440269
Thanks for the contribution - closing after a detailed look, since this can't land in its current shape and the ground has shifted under it: 1. **Compile error**: `if (isJava11Or17) return` inside a FunSuite test body is illegal Scala (`return` outside a method definition) - this is why the `build-spark-*` checks are red. 2. **The guard defeats the purpose**: every CI job that selects `org.apache.spark.sql.hudi.dml.insert` suites runs JDK 11 or 17 (GitHub Actions and Azure), so with the guard in place the new tests would be skipped everywhere and add no running coverage. 3. **Blocked on current master anyway**: with the guard removed, the suite aborts on any JDK with `NoClassDefFoundError: org.apache.thrift.transport.layered.TFramedTransport` - `hive.version=2.3.10` needs libthrift >= 0.13, but hudi-spark's test classpath resolves libthrift 0.12.0 from Spark 3.5. The coverage gap this PR targets is real - HUDI-9678 escaped precisely because nothing tests SQL writes against an HMS-backed catalog - so #19296 now tracks the libthrift/Hive alignment and the CI filter fix as prerequisites. Happy to see this revived once those land. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
