hudi-agent commented on code in PR #18923:
URL: https://github.com/apache/hudi/pull/18923#discussion_r3586430045
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetReader.java:
##########
@@ -144,16 +144,28 @@ public ClosableIterator<UnsafeRow>
getUnsafeRowIterator(HoodieSchema requestedSc
*/
public ClosableIterator<UnsafeRow> getUnsafeRowIterator(HoodieSchema
requestedSchema, List<Filter> readFilters) throws IOException {
HoodieSchema nonNullSchema = requestedSchema.getNonNullType();
- StructType structSchema =
HoodieInternalRowUtils.getCachedSchema(nonNullSchema);
+ return getUnsafeRowIterator(nonNullSchema,
HoodieInternalRowUtils.getCachedSchema(nonNullSchema), readFilters);
+ }
+
+ /**
+ * Variant overload. {@code projectedStructSchema} is the requested Spark
schema, which may carry
Review Comment:
🤖 nit: the first Javadoc sentence "Variant overload." describes the category
of the method rather than what it does — IDE hover tooltips truncate at the
first `.`, so a developer will just see that label. Could you replace it with
something like "Returns an unsafe-row iterator using {@code
projectedStructSchema} as the Spark read schema directly, preserving any Spark
4.1 {@code VariantMetadata} on variant fields that {@link HoodieSchema} cannot
encode"?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
