danny0405 commented on code in PR #19247:
URL: https://github.com/apache/hudi/pull/19247#discussion_r3586434125
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/NativeLogFooterMetadata.java:
##########
@@ -24,95 +24,77 @@
import org.apache.hudi.common.model.LogExtensions;
import org.apache.hudi.common.schema.HoodieSchema;
import
org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType;
-import org.apache.hudi.common.util.JsonUtils;
import org.apache.hudi.common.util.StringUtils;
import org.apache.hudi.core.io.storage.HoodieIOFactory;
import org.apache.hudi.exception.HoodieIOException;
import org.apache.hudi.exception.HoodieNotSupportedException;
import org.apache.hudi.storage.HoodieStorage;
import org.apache.hudi.storage.StoragePath;
-import com.fasterxml.jackson.core.type.TypeReference;
-
-import java.io.IOException;
import java.util.LinkedHashMap;
import java.util.Map;
/**
- * Shared on-disk contract for RFC-103 native log files. The log block header
(schema, instant time,
- * etc.) is persisted as a single JSON entry in the native file footer, keyed
by
- * {@link #FOOTER_METADATA_KEY}. This is the single source of truth used by
both the write path
- * ({@code HoodieNativeLogFormatWriter}) and the read path ({@code
HoodieNativeLogFileReader}) so the
- * two cannot drift apart.
+ * Shared on-disk contract for RFC-103 native log files. Each log block header
entry (schema,
+ * instant time, etc.) is persisted as a separate, namespaced entry in the
native file footer.
+ * This is the single source of truth used by both the write path ({@code
HoodieNativeLogFormatWriter})
+ * and the read path ({@code HoodieNativeLogFileReader}) so the two cannot
drift apart.
*/
public class NativeLogFooterMetadata {
/**
- * Footer key under which the serialized log block header is stored in a
native log file.
+ * Prefix for log format metadata entries stored in a native log file footer.
*/
- public static final String FOOTER_METADATA_KEY = "hudi.log.format.metadata";
Review Comment:
this PR is aborted, there is little gains here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
