cshuo commented on code in PR #19293:
URL: https://github.com/apache/hudi/pull/19293#discussion_r3592588188
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/profile/DeltaWriteProfile.java:
##########
@@ -123,10 +123,9 @@ private boolean isSmallFile(FileSlice fileSlice) {
}
private double logFileToParquetCompressionRatio() {
- if (config.getLogDataBlockFormat().isPresent()
- && config.getLogDataBlockFormat().get() ==
HoodieLogBlock.HoodieLogBlockType.PARQUET_DATA_BLOCK) {
- return 1D;
+ if (config.getWriteVersion().lesserThan(HoodieTableVersion.TEN)) {
+ return config.getLogFileToParquetCompressionRatio();
Review Comment:
Should we retain the `PARQUET_DATA_BLOCK` guard here?
`hoodie.logfile.data.block.format=parquet` is still supported for legacy v9
tables, where applying the configured fraction recalibrates physical Parquet
log sizes and affects both average record-size estimation and bucket sizing.
The previous regression test covered this case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
