danny0405 commented on code in PR #19293:
URL: https://github.com/apache/hudi/pull/19293#discussion_r3594233951
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -106,6 +106,9 @@ case class HoodieFileIndex(spark: SparkSession,
@transient protected var hasPushedDownPartitionPredicates: Boolean = false
+ private lazy val hoodieConfig =
Review Comment:
Done in `ee04a6508a38`. I marked the derived `hoodieConfig` as `@transient
private lazy val`, consistent with the neighboring driver-side derived state.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestPartitionDirectoryConverter.scala:
##########
@@ -49,6 +51,7 @@ class TestPartitionDirectoryConverter extends
SparkAdapterSupport {
val options = Map(
s"${HoodieStorageConfig.LOGFILE_TO_PARQUET_COMPRESSION_RATIO_FRACTION.key()}"
-> logFraction.toString
)
+ val config = new HoodieConfig(TypedProperties.fromMap(options.asJava))
Review Comment:
Added a dedicated `testConvertNativeLogFileSliceToPartitionDirectory` in
`ee04a6508a38`. It constructs a native `.log.parquet` slice, verifies it is
recognized as native, and asserts the Spark delegate file keeps the native log
physical size instead of applying the inline-log fraction. All 7
`TestPartitionDirectoryConverter` tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
