voonhous commented on code in PR #19120:
URL: https://github.com/apache/hudi/pull/19120#discussion_r3602362032
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/client/common/TestMultipleHoodieJavaWriteClient.java:
##########
@@ -207,8 +208,14 @@ record -> {
String startCommitTime = writer.startCommit();
List<WriteStatus> s =
writer.upsert(Collections.singletonList(record), startCommitTime);
- writer.commit(startCommitTime, s);
- LOGGER.info("Completed commit");
+ try {
+ writer.commit(startCommitTime, s);
+ LOGGER.info("Completed commit");
Review Comment:
No longer relevant -- this file was dropped from the PR (the OCC fix already
landed in master via #19124), so no assertion change is needed here.
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/client/common/TestMultipleHoodieJavaWriteClient.java:
##########
@@ -207,8 +208,14 @@ record -> {
String startCommitTime = writer.startCommit();
List<WriteStatus> s =
writer.upsert(Collections.singletonList(record), startCommitTime);
- writer.commit(startCommitTime, s);
- LOGGER.info("Completed commit");
+ try {
+ writer.commit(startCommitTime, s);
+ LOGGER.info("Completed commit");
+ } catch (HoodieWriteConflictException e) {
+ // OCC conflict is expected when multiple writers operate
concurrently on overlapping key ranges.
+ // The test verifies no deadlock occurs, not that every commit
succeeds.
+ LOGGER.info("Write conflict on commit {}, expected OCC
behavior: {}", startCommitTime, e.getMessage());
Review Comment:
No longer relevant -- same reason, this file left the PR (#19124 covers it
in master).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
