nsivabalan commented on code in PR #19045:
URL: https://github.com/apache/hudi/pull/19045#discussion_r3611503639
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -383,6 +383,29 @@ public static final String getDefaultPayloadClassName() {
.sinceVersion("1.1.0")
.withDocumentation("This property when set, will define how two versions
of the record will be merged together when records are partially formed");
+ public static final ConfigProperty<String> METADATA_LAYOUT_CLASS =
ConfigProperty
+ .key("hoodie.metadata.layout.class")
+ .noDefaultValue()
+ .sinceVersion("1.3.0")
+ .withDocumentation("Fully-qualified class name of the
HoodieMetadataTableLayout implementation that organizes "
+ + "MDT file groups on disk. When unset, MDT uses the flat layout
(file groups directly under each metadata "
Review Comment:
Done in `92fe6e19`. `HoodieTableConfig.METADATA_LAYOUT_CLASS` doc now
enumerates the OOB values, mirroring the `HoodieMetadataConfig` side.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -383,6 +383,29 @@ public static final String getDefaultPayloadClassName() {
.sinceVersion("1.1.0")
.withDocumentation("This property when set, will define how two versions
of the record will be merged together when records are partially formed");
+ public static final ConfigProperty<String> METADATA_LAYOUT_CLASS =
ConfigProperty
+ .key("hoodie.metadata.layout.class")
+ .noDefaultValue()
+ .sinceVersion("1.3.0")
+ .withDocumentation("Fully-qualified class name of the
HoodieMetadataTableLayout implementation that organizes "
+ + "MDT file groups on disk. When unset, MDT uses the flat layout
(file groups directly under each metadata "
+ + "partition). Set once at MDT initialization; immutable
thereafter.");
+
+ public static final ConfigProperty<Integer> METADATA_LAYOUT_BUCKET_SIZE =
ConfigProperty
+ .key("hoodie.metadata.layout.bucket.size")
+ .defaultValue(1000)
+ .sinceVersion("1.3.0")
+ .withDocumentation("Layout-specific: maximum number of file groups per
bucket sub-directory when the layout is "
Review Comment:
Done in `92fe6e19`. `HoodieTableConfig.METADATA_LAYOUT_BUCKET_SIZE` doc now
cross-references `hoodie.metadata.layout.class`.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -383,6 +383,29 @@ public static final String getDefaultPayloadClassName() {
.sinceVersion("1.1.0")
.withDocumentation("This property when set, will define how two versions
of the record will be merged together when records are partially formed");
+ public static final ConfigProperty<String> METADATA_LAYOUT_CLASS =
ConfigProperty
+ .key("hoodie.metadata.layout.class")
+ .noDefaultValue()
+ .sinceVersion("1.3.0")
+ .withDocumentation("Fully-qualified class name of the
HoodieMetadataTableLayout implementation that organizes "
+ + "MDT file groups on disk. When unset, MDT uses the flat layout
(file groups directly under each metadata "
+ + "partition). Set once at MDT initialization; immutable
thereafter.");
+
+ public static final ConfigProperty<Integer> METADATA_LAYOUT_BUCKET_SIZE =
ConfigProperty
+ .key("hoodie.metadata.layout.bucket.size")
+ .defaultValue(1000)
+ .sinceVersion("1.3.0")
+ .withDocumentation("Layout-specific: maximum number of file groups per
bucket sub-directory when the layout is "
+ + "SubDirBucketedMDTLayout. Ignored otherwise.");
+
+ public static final ConfigProperty<String>
METADATA_LAYOUT_PARTITION_FILE_GROUP_COUNTS = ConfigProperty
+ .key("hoodie.metadata.layout.partition.file.group.counts")
Review Comment:
Done in `8a7c60f5`. Renamed the key to
`hoodie.metadata.layout.bucketed.file.group.per.bucket` — matches the semantics
"how many file groups share one bucket" and removes the naming collision with
the existing MDT partition file-group-count knobs (col_stats, RLI, etc.). The
Java accessor `getMetadataLayoutBucketSize()` name is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
