nsivabalan commented on PR #19320: URL: https://github.com/apache/hudi/pull/19320#issuecomment-5023573910
Thanks @wombatu-kun and @voonhous for the careful review. Pushed two commits addressing the feedback: - **LevelDB link** — now points at `google/leveldb/blob/main/doc/impl.md#compactions` (both of you flagged this). - **Series list entry #4** — updated with the new title after the rename. - **Consolidation pass** — applied the concrete cuts you outlined: 2017/2019 framing once (in the intro), "principles only matter if behavior changes" question once (at the end of Separating Correctness from Optimization), workloads story once (in The Workloads Changed), and dropped the redundant closing restatements. Ended up trimming ~35 lines / ~500 words. Also took the opportunity to name Iceberg and Delta explicitly in Two Architectural Philosophies rather than hedging as "one school of thought" — earns the comparative framing. - **Benchmark figure caption** — reframed to describe *the outcomes the benchmark is designed to distinguish* rather than which engine lands where. Same figure, honest caption. - **NBCC link** — added to `/docs/concurrency_control#non-blocking-concurrency-control`. - **PNG sizes** — passed all three through `pngquant --quality 80-95 --strip`. Payload dropped from ~4.5MB to ~1.4MB (~70% smaller), no visible quality change. **Left open (with a note):** the *Cleaning* vs *Cleanup* label mismatch between the two diagrams — that needs a re-export from the diagram source rather than a text edit. I'll fix it in a follow-up commit if I end up re-exporting either image for other reasons; otherwise flagging for the next post in the series where I can align both from the start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
