voonhous commented on PR #19334: URL: https://github.com/apache/hudi/pull/19334#issuecomment-5044182924
Two pre-existing things spotted while reviewing, not blockers: - `IMetaStoreClient` isn't thread-safe but is shared between the heartbeat thread and callers - `future` is read/written across threads without `volatile` Both unchanged by this PR; flagging in case anyone wants a follow-up issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
