wombatu-kun commented on PR #18837: URL: https://github.com/apache/hudi/pull/18837#issuecomment-5044175828
Filed #19344 with 12 code-level defects in the connector. None of them is caused by this PR, so none is review feedback on it, and the issue stands on its own whatever you decide here. Items 5, 10, 11 and 12 are one- or two-line changes (nothing asserts `getRetainedSizeInBytes`, so 12 is free). If they are convenient to fold in while you are already in these files, that saves a round trip; otherwise they stay in the issue and nothing is lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
