wombatu-kun commented on code in PR #19365:
URL: https://github.com/apache/hudi/pull/19365#discussion_r3642531281
##########
.github/workflows/bot.yml:
##########
@@ -1176,7 +1176,7 @@ jobs:
- scalaProfile: 'scala-2.13'
flinkProfile: 'flink1.20'
sparkProfile: 'spark4.2'
- sparkRuntime: 'spark4.2.0-preview4'
+ sparkRuntime: 'spark4.2.0'
Review Comment:
`release_candidate_validation.yml` has no spark4.2 entry in
`validate-release-candidate-bundles-spark4`, so the `hudi-spark4.2-bundle_2.13`
that `validate_staged_bundles.sh` already expects never gets bundle-validated
at RC time. Now that 4.2 is GA rather than a preview, worth adding the matching
`spark4.2` / `spark4.2.0` pair there - follow-up, not a blocker.
##########
packaging/bundle-validation/validate.sh:
##########
@@ -80,7 +80,7 @@ use_default_java_runtime () {
test_spark_hadoop_mr_bundles () {
echo "::warning::validate.sh setting up hive metastore for spark &
hadoop-mr bundles validation"
- if [ "$SPARK_VERSION" = "4.0.0" ] || [ "$SPARK_VERSION" = "4.1.1" ] || [
"$SPARK_VERSION" = "4.2.0-preview4" ]; then
+ if [ "$SPARK_VERSION" = "4.0.0" ] || [ "$SPARK_VERSION" = "4.1.1" ] || [
"$SPARK_VERSION" = "4.2.0" ]; then
Review Comment:
Every Spark 4 bump has to edit this same literal version list in three
separate places in this file. Worth collapsing the three conditions to a `[[
"$SPARK_VERSION" == 4.* ]]` glob so the next bump does not touch validate.sh at
all - follow-up, not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
