danny0405 commented on code in PR #19359:
URL: https://github.com/apache/hudi/pull/19359#discussion_r3642687179
##########
hudi-common/src/main/java/org/apache/hudi/metadata/MetadataPartitionType.java:
##########
@@ -510,7 +510,7 @@ public static boolean
isNewSecondaryIndexDefinitionRequired(HoodieMetadataConfig
return false;
}
// check the index definition already exists or not for this column
- List<HoodieIndexDefinition> indexDefinitions =
getIndexDefinitions(secondaryIndexColumn, PARTITION_NAME_SECONDARY_INDEX,
dataMetaClient);
+ List<HoodieIndexDefinition> indexDefinitions =
getIndexDefinitions(PARTITION_NAME_SECONDARY_INDEX, secondaryIndexColumn,
dataMetaClient);
Review Comment:
This is a production behavior change, although the PR title and Impact
section say the change is test-only with no functional impact. Swapping these
arguments fixes existing secondary/expression definitions never being matched,
which changes whether writers try to create a new definition. Please call this
bug fix out in the Summary/Impact (and preferably the commit title) so release
notes and risk review do not miss it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
