wombatu-kun commented on PR #19371: URL: https://github.com/apache/hudi/pull/19371#issuecomment-5090973559
On the second reason: with `this.lock == null` invariant at the catch site the outer `if (this.lock == null || this.lock.getState() != ACQUIRED)` is a tautology, so what it kills is that second disjunct and the implicit fall-through that swallowed the exception when a lock was already held, while the inner adopt branch reads only what `checkLock` returns and a correct lock id would have made it reachable. Leaving the body as is on that basis, since the txnid-0 argument stays the only reason the recovery was dead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
