cshuo commented on code in PR #19385:
URL: https://github.com/apache/hudi/pull/19385#discussion_r3662547540
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ArchivedTimelineV2.java:
##########
@@ -147,7 +147,7 @@ public void loadCompactionDetailsInMemory(String
compactionInstantTime) {
public void loadCompactionDetailsInMemory(String startTs, String endTs) {
// load compactionPlan
- List<HoodieInstant> loadedInstants = loadInstants(new
HoodieArchivedTimeline.TimeRangeFilter(startTs, endTs),
HoodieArchivedTimeline.LoadMode.PLAN,
+ List<HoodieInstant> loadedInstants = loadInstants(new
HoodieArchivedTimeline.ClosedClosedTimeRangeFilter(startTs, endTs),
HoodieArchivedTimeline.LoadMode.PLAN,
Review Comment:
Should `loadCompletedInstantDetailsInMemory` also use
`ClosedClosedTimeRangeFilter`? The current filter excludes `startTs` and is
inconsistent with V1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
