codope commented on code in PR #18988:
URL: https://github.com/apache/hudi/pull/18988#discussion_r3663281281
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -424,6 +424,8 @@ protected void completeCompaction(HoodieCommitMetadata
metadata, HoodieTable tab
);
}
log.info("Compacted successfully on commit {}", compactionCommitTime);
+ fireCommitCallbackIfNecessary(compactionCommitTime,
HoodieTimeline.COMMIT_ACTION,
Review Comment:
Wired in..
`HoodieFlinkTableServiceClient.completeCompaction`/`completeClustering` now
fire the callback too
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/callback/common/HoodieWriteCommitCallbackMessage.java:
##########
@@ -69,10 +70,54 @@ public class HoodieWriteCommitCallbackMessage implements
Serializable {
*/
private final Option<Map<String, String>> extraMetadata;
+ /**
+ * Previous base file paths keyed by fileId. Populated by the write client
+ * using the cached FileSystemView so that callback implementations don't
+ * have to rebuild a view. Empty for inserts and for callers that don't
+ * pre-resolve.
+ */
+ private final Map<String, PrevFilePaths> prevFilePaths;
+
+ /**
+ * Free-form context that producers can attach for downstream callback
consumers.
+ * The OSS write client populates this as empty; specialized callsites or
wrappers
+ * may populate it with whatever context their callbacks need. Mirrors the
Review Comment:
dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
