hudi-agent commented on code in PR #19393: URL: https://github.com/apache/hudi/pull/19393#discussion_r3665057328
########## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/catalog/TestHoodieCatalogUtil.java: ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.table.catalog; + +import org.apache.hudi.configuration.FlinkOptions; +import org.apache.hudi.utils.CatalogUtils; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.catalog.CatalogPartitionSpec; +import org.apache.flink.table.catalog.CatalogTable; +import org.apache.flink.table.catalog.ObjectPath; +import org.apache.flink.table.catalog.exceptions.CatalogException; +import org.apache.flink.table.catalog.exceptions.PartitionSpecInvalidException; +import org.apache.hadoop.hive.conf.HiveConf; +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.Map; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * Tests for {@link HoodieCatalogUtil}. + */ +class TestHoodieCatalogUtil { + + @Test + void testPartitionKeyAndPathHelpers() { + Schema schema = Schema.newBuilder() + .column("id", DataTypes.INT()) Review Comment: 🤖 nit: `testPartitionKeyAndPathHelpers` — "Helpers" is a bit opaque about what's actually being validated; something like `testPartitionKeyExtractionAndPathInference` would make the coverage clearer at a glance. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> ########## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/catalog/TestHoodieHiveCatalog.java: ########## @@ -149,6 +164,259 @@ public static void closeCatalog() { } } + @Test Review Comment: 🤖 nit: `testDatabaseAndTableApiAgainstMetastore` is ~200 lines and exercises database CRUD, table creation, Hive sync option injection, and drop-ordering all in one go — could you split it into something like `testDatabaseLifecycle`, `testTableLifecycleAgainstMetastore`, and `testHiveSyncOptionsInjected`? That would make it much easier to locate coverage for a specific scenario and add assertions without touching unrelated setup. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
