yihua commented on code in PR #19388: URL: https://github.com/apache/hudi/pull/19388#discussion_r3667566745
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/SimpleSchemaConflictResolutionStrategy.java: ########## @@ -157,9 +155,9 @@ public Option<HoodieSchema> resolveConcurrentSchemaEvolution( } private Option<HoodieInstant> getInstantInTimelineImmediatelyPriorToTimestamp( Review Comment: This is existing code, so I will keep it as is for simplicity of this PR. ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/SimpleSchemaConflictResolutionStrategy.java: ########## @@ -157,9 +155,9 @@ public Option<HoodieSchema> resolveConcurrentSchemaEvolution( } private Option<HoodieInstant> getInstantInTimelineImmediatelyPriorToTimestamp( Review Comment: This is existing code, so I will keep it as is for the simplicity of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
