hudi-agent commented on code in PR #19390:
URL: https://github.com/apache/hudi/pull/19390#discussion_r3670514971
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/WriterHelpers.java:
##########
@@ -32,8 +33,18 @@
public class WriterHelpers {
public static BulkInsertWriterHelper getWriterHelper(Configuration conf,
HoodieTable<?, ?, ?, ?> hoodieTable, HoodieWriteConfig writeConfig,
String instantTime, int
taskPartitionId, long taskId, long taskEpochId, RowType rowType) {
- return OptionsResolver.isBucketIndexType(conf)
- ? new BucketBulkInsertWriterHelper(conf, hoodieTable, writeConfig,
instantTime, taskPartitionId, taskId, taskEpochId, rowType)
- : new BulkInsertWriterHelper(conf, hoodieTable, writeConfig,
instantTime, taskPartitionId, taskId, taskEpochId, rowType);
+ if (OptionsResolver.isLsmTreeStorageLayout(conf)) {
+ return OptionsResolver.isBucketIndexType(conf)
+ ? new LsmBucketBulkInsertWriterHelper(
+ conf, hoodieTable, writeConfig, instantTime, taskPartitionId,
taskId, taskEpochId, rowType)
+ : new LsmBulkInsertWriterHelper(
+ conf, hoodieTable, writeConfig, instantTime, taskPartitionId,
taskId, taskEpochId, rowType);
+ } else {
+ return OptionsResolver.isBucketIndexType(conf)
+ ? new BucketBulkInsertWriterHelper(
+ conf, hoodieTable, writeConfig, instantTime, taskPartitionId,
taskId, taskEpochId, rowType)
Review Comment:
🤖 nit: the `conf` argument here is indented to the `?` level rather than the
constructor argument level — could you align it with the `conf` on line 39/47
(` conf, ...`) to match the other three constructor calls in this
method?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
