voonhous opened a new issue, #19412: URL: https://github.com/apache/hudi/issues/19412
Parent: #18780 (RFC-105). ## Context `hudi-trino` was migrated from trinodb/trino (RFC-105) and still carries Trino conventions: - All java files under `hudi-trino/src` carry the short "Licensed under the Apache License, Version 2.0" header instead of the ASF header used everywhere else in the repo. RAT accepts them via its default AL matcher, but nothing enforces the repo-standard header. - The module sets `checkstyle.skip=true` in its pom, and the airbase check stack (`com.mycila:license-maven-plugin`, Trino checkstyle, modernizer) stopped applying when RFC-105 re-parented the module from `io.trino:trino-root` to the Hudi root pom. Net result: no style or header enforcement at all today. Per RFC-105 the connector's canonical home is now apache/hudi -- the Trino side becomes a thin shim consuming `org.apache.hudi:hudi-trino` and connector source no longer syncs back upstream -- so there is no reason to keep Trino formatting. ## Scope 1. Convert license headers in `hudi-trino/src` to the standard ASF header (the root pom RAT config already matches it). Update the RAT comment in `.github/workflows/bot.yml` that documents the current AL-header situation. 2. Remove `checkstyle.skip=true` from `hudi-trino/pom.xml`, run Hudi checkstyle over the module, and fix violations (large mechanical reformat: indentation, import order). 3. Land the header conversion and the reformat as separate commits; add a `.git-blame-ignore-revs` listing the reformat commit (the repo does not have one yet). 4. Wire checkstyle into `hudi_trino_ci.yml` so the module stays enforced going forward. ## Out of scope - Package rename: code stays at `io.trino.plugin.hudi.*`, required by the Trino-side shim design (RFC-105). - The mirrored smoke tests on the Trino side keep Trino conventions in trinodb/trino. ## Sequencing Do this after the in-flight hudi-trino release-staging work (#19410) merges, to avoid conflicting with open PRs. The reformat has no effect on the released artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
