voonhous commented on code in PR #19410:
URL: https://github.com/apache/hudi/pull/19410#discussion_r3682599464
##########
hudi-trino/pom.xml:
##########
@@ -595,6 +595,17 @@
<annotationProcessorPaths combine.self="override"/>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <!-- The parent release profile pins javadoc source to 11,
which rejects records
+ (a Java 16 feature); follow hudi.trino.java.version
instead. -->
+ <source>${hudi.trino.java.version}</source>
+ <!-- The release profile also sets failOnError=false; this
module's javadoc is clean, keep breaks loud. -->
+ <failOnError>true</failOnError>
Review Comment:
Fair point, finding out during the staging deploy is too late. Added a
javadoc step to `hudi_trino_ci.yml` that runs `javadoc:jar` with the same
effective config as the release deploy (`doclint=none` plus the module's
`failOnError=true`), so a break now fails the PR instead of the staging run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
