hudi-agent commented on code in PR #19425:
URL: https://github.com/apache/hudi/pull/19425#discussion_r3686292917
##########
packaging/hudi-utilities-bundle/pom.xml:
##########
@@ -153,6 +153,11 @@
<include>com.101tec:zkclient</include>
<include>org.apache.kafka:kafka-clients</include>
+ <!-- AWS SDK for JsonKinesisSource; relocated below,
matching hudi-aws-bundle. -->
+ <include>software.amazon.awssdk:*</include>
+ <!-- KPL de-aggregation: extracts user records from Kinesis
Producer Library aggregated records -->
+ <include>com.amazonaws:amazon-kinesis-deaggregator</include>
Review Comment:
🤖 This includes `amazon-kinesis-deaggregator` but not
`com.amazonaws:amazon-kinesis-client`. `KinesisDeaggregator` imports
`com.amazonaws.services.kinesis.clientlibrary.types.UserRecord`, which lives in
`amazon-kinesis-client` (pulled in transitively at 1.8.8), not in the
deaggregator artifact — so the standalone bundle would still hit
`NoClassDefFoundError` on `UserRecord`. Note `hudi-aws-bundle` includes both
`amazon-kinesis-deaggregator` and `amazon-kinesis-client`. Could you add the
`amazon-kinesis-client` include here to match?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
