vinothchandar commented on pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#issuecomment-806141760


   Let me see how/if we can simplify the inputSchema vs writeSchema thing. 
   
   I went over the PR now. LGTM at a high level. 
   Few questions though 
   
   - I see we are introducing some antlr parsing and inject a custom parse for 
spark 2.x. Is this done for backwards compat with Spark 2 and will be 
eventually removed?
   - Do we reuse the MERGE/DELETE keywords from Spark 3? Is Spark 3 and Spark 2 
syntax different. Can you comment on how we are approaching all this.
   - Have you done any production testing of this PR? 
   
   
   cc @kwondw could you also please chime in. We would like to land something 
basic and iterate and get this out for 0.9.0 next month. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to