voonhous opened a new pull request, #19458:
URL: https://github.com/apache/hudi/pull/19458
The rule only rewrites LogicalRelation(relation: HoodieBaseRelation) when
relation.canPruneRelationSchema is true. Since #14061 removed the
FILE_GROUP_READER_ENABLED fallback from DefaultSource and #17457 finished the
FileGroupReader migration, every non-metadata read returns a HadoopFsRelation;
the only remaining HoodieBaseRelation producers are metadata-table reads and
the schema-on-read branch, both of which canPruneRelationSchema rejects, so the
rule can never fire. Nested schema pruning for users is performed by Spark's
built-in SchemaPruning, since the file-group-reader file format extends
ParquetFileFormat.
Also remove the members stranded by the rule: canPruneRelationSchema,
updatePrunedDataSchema, dataSchema, type Relation and the prunedDataSchema
constructor parameter on HoodieBaseRelation and its subclasses,
MergeOnReadSnapshotRelation.isProjectionCompatible, and
BaseHoodieCatalystPlanUtils.projectOverSchema.
TestNestedSchemaPruningOptimization is kept unchanged; it covers the
Spark-native pruning path (FileSourceScanExec.requiredSchema) that serves users
today.
Fixes #19447
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
