voonhous commented on code in PR #19459:
URL: https://github.com/apache/hudi/pull/19459#discussion_r3699466737
##########
website/versioned_docs/version-1.0.0/concurrency_control.md:
##########
@@ -244,7 +244,7 @@ hoodie.cleaner.policy.failed.writes=LAZY
| Config Name | Default
| Description
|
|-------------------------------------|-------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| hoodie.write.concurrency.mode | SINGLE_WRITER (Optional)
| <u>[Concurrency
modes](https://github.com/apache/hudi/blob/00ece7bce0a4a8d0019721a28049723821e01842/hudi-common/src/main/java/org/apache/hudi/common/model/WriteConcurrencyMode.java)</u>
for write operations.<br />Possible values:<br /><ul><li>`SINGLE_WRITER`: Only
one active writer to the table. Maximizes
throughput.</li><li>`OPTIMISTIC_CONCURRENCY_CONTROL`: Multiple writers can
operate on the table with lazy conflict resolution using locks. This means that
only one writer succeeds if multiple writers write to the same file
group.</li><li>`NON_BLOCKING_CONCURRENCY_CONTROL`: Multiple writers can operate
on the table with non-blocking conflict resolution. The writers can write into
the same file group with the conflicts resolved automatically by the query
reader and the compactor.</li></ul><br />`Config Param: WRITE_CONCURRENCY_MODE`
|
-| hoodie.write.lock.provider |
org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider (Optional) |
Lock provider class name, user can provide their own implementation of
LockProvider which should be subclass of
org.apache.hudi.common.lock.LockProvider<br /><br />`Config Param:
LOCK_PROVIDER_CLASS_NAME`<br />`Since Version: 0.8.0`
|
+| hoodie.write.lock.provider |
org.apache.hudi.client.transaction.lock.InProcessLockProvider (Optional) |
Lock provider class name, user can provide their own implementation of
LockProvider which should be subclass of
org.apache.hudi.common.lock.LockProvider<br /><br />`Config Param:
LOCK_PROVIDER_CLASS_NAME`<br />`Since Version: 0.8.0`
|
Review Comment:
Correct as written. `release-1.0.0` has
`.defaultValue(InProcessLockProvider.class.getName())`, set by `77f6869d3fd5`
"[HUDI-8594] Make InProcessLockProvider as default (#12347)", and
`versioned_docs/version-1.0.0/configurations.md` agrees.
This is the only version where `InProcessLockProvider (Optional)` is the
right value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
