voonhous commented on code in PR #19217: URL: https://github.com/apache/hudi/pull/19217#discussion_r3701771618
########## .github/workflows/hudi_trino_e2e.yml: ########## @@ -0,0 +1,157 @@ +name: Hudi Trino E2E + +on: + push: + branches: + - master + - 'release-*' + # TEMPORARY: validate the workflow on the dev branch; drop this line + # (and the commit that added it) before merging upstream. + - trino-e2e-testcontainers Review Comment: Done -- dropped the dev-branch push trigger line. `pull_request` + `workflow_dispatch` still cover CI for this PR. ########## .github/workflows/hudi_trino_e2e.yml: ########## @@ -0,0 +1,157 @@ +name: Hudi Trino E2E + +on: + push: + branches: + - master + - 'release-*' + # TEMPORARY: validate the workflow on the dev branch; drop this line + # (and the commit that added it) before merging upstream. + - trino-e2e-testcontainers + paths: + - 'hudi-trino/**' + - 'docker/trino/**' + - 'docker/compose/docker-compose_hadoop340_hive2310_spark402*' + - 'docker/demo/sparksql-stock-ticks-trino.commands' + - 'hudi-integ-test/src/test/java/org/apache/hudi/integ2/**' + - '.github/workflows/hudi_trino_e2e.yml' + pull_request: + branches: + - master + - 'release-*' + paths: + - 'hudi-trino/**' + - 'docker/trino/**' + - 'docker/compose/docker-compose_hadoop340_hive2310_spark402*' + - 'docker/demo/sparksql-stock-ticks-trino.commands' Review Comment: Widened to `docker/demo/**` in both the `push` and `pull_request` filters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
