deepakpanda93 commented on PR #14101: URL: https://github.com/apache/hudi/pull/14101#issuecomment-5166533644
Closing in favour of #19489. `docker/build_docker_images.sh` was substantially rewritten on master after this PR was opened, and this PR replaces that file with a copy forked from the older version. Rebasing would therefore have reverted the named version flags, the `pom.xml`-derived version tag, the Java 11/17 base selection and the multi-arch support that landed since. #19489 is a fresh port of the same idea onto the current script instead. Both review comments here are addressed there: - merged into a single script rather than a second one, with `--publish <true|false>` defaulting to false - the header describes what the script does and that publishing is for maintainers, reachable via `--help` - the flag is named `--publish` and takes an explicit value, as suggested Thanks @xushiyan for the review, and @yihua for the nudge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
