voonhous opened a new pull request, #19495:
URL: https://github.com/apache/hudi/pull/19495
…mn values
Follow-up to #19483, addressing wombatu-kun's review comments.
The decimal schema cache was unnecessary rather than merely mis-keyed.
Avro's DecimalConversion.fromBytes reads only the scale (it never touches
precision, and ignores its schema argument), and
Decimals.encodeShortScaledValue then calls setScale to that same scale, which
returns the BigDecimal unchanged. The pair reduces to new
BigInteger(fixed.bytes()).longValueExact(), so AvroDecimalConverter and its
ConcurrentHashMap are deleted instead of re-keyed.
PrefilledColumnValues resolved every value through
HiveUtil.getPrefilledColumnValue on each call, and appendTo runs once per
prefilled column per record. Every input is a split constant, so the resolved
value is now memoized per column.
Tests: the decimal test now drives the public appendTo path over scales,
signs and the widest short decimal rather than the deleted converter; it passes
against both the old and new implementations. Added repeated resolution of a
hive-null column, the case a naive memo would get wrong.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
