hudi-agent commented on code in PR #19494:
URL: https://github.com/apache/hudi/pull/19494#discussion_r3706091721
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/model/TestHoodiePartitionMetadata.java:
##########
@@ -89,6 +107,116 @@ public void
testTextFormatMetaFile(Option<HoodieFileFormat> format) throws IOExc
assertEquals(3, readMetadata.getPartitionDepth());
Review Comment:
🤖 nit: `TestLogAppender` is defined identically in both `TestRetryHelper`
and `TestHoodiePartitionMetadata` — could it live in a shared test-utility
class (e.g. `HoodieTestLogAppender` under a `testutils` module) so the two test
files can just import it?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/common/util/RetryHelper.java:
##########
@@ -122,6 +127,20 @@ public T start() throws R {
return start(this.func);
}
+ /**
+ * Renders an exception as a single line, keeping the root cause so that the
warning stays
+ * actionable without the whole stack trace.
+ */
+ @VisibleForTesting
+ static String summarise(Throwable t) {
+ Throwable rootCause = t;
Review Comment:
🤖 nit: `summarise` uses British spelling — could you rename it to
`summarize` to stay consistent with Java's own conventions and the rest of the
Hudi codebase (e.g. `Collectors.summarizingInt`, `DoubleSummaryStatistics`)?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
