danny0405 commented on code in PR #19464:
URL: https://github.com/apache/hudi/pull/19464#discussion_r3708642343
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -644,7 +645,7 @@ private void completeClustering(HoodieReplaceCommitMetadata
replaceCommitMetadat
heartbeatClient.stop(clusteringCommitTime);
}
log.info("Clustering successfully on commit {} for table {}",
clusteringCommitTime, table.getConfig().getBasePath());
- fireCommitCallbackIfNecessary(clusteringCommitTime,
clusteringInstant.getAction(),
+ fireCommitCallbackIfNecessary(clusteringCommitTime,
completedClusteringInstant.getAction(),
Review Comment:
I don't see the reason why we need the action type for timeline instant
filtering, the instant time is already passed in there and we know the instant
is complete when calling the callback, the action type should just be a marker
of what kidn of instant it was?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
