danny0405 opened a new pull request, #19503:
URL: https://github.com/apache/hudi/pull/19503

   ### Describe the issue this Pull Request addresses
   
   Flink lookup cache reloads closed the table reader only after a complete, 
successful read. If opening or reading an input format failed, the retry opened 
another input format while the previous attempt could still hold file handles 
or native reader resources.
   
   ### Summary and Changelog
   
   - Close the lookup table reader in a `finally` block for every cache reload 
attempt.
   - Roll back partially opened input formats and make reader cleanup 
idempotent.
   - Attempt rich input-format cleanup even when split cleanup fails, 
preserving secondary failures as suppressed exceptions.
   - Add regression coverage for reload failures, partial-open rollback, and 
close failures.
   
   No code was copied from another project.
   
   ### Impact
   
   No public API, configuration, storage-format, or performance behavior 
changes. Failed Flink lookup cache reloads no longer accumulate input-format 
resources across local retries.
   
   ### Risk Level
   
   low. The change is limited to lookup reader resource cleanup and is covered 
by focused success and failure-path tests.
   
   ### Documentation Update
   
   none.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   
   ### Testing
   
   - `mvn -pl hudi-flink-datasource/hudi-flink -DskipITs -Dcheckstyle.skip 
-Drat.skip=true -Dtest=TestHoodieLookupFunction,TestHoodieLookupTableReader 
test` (6 tests passed)
   - `mvn -pl hudi-flink-datasource/hudi-flink checkstyle:check 
-Dcheckstyle.includes='**/table/lookup/*.java'` (0 violations)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to