rangareddy commented on code in PR #19476:
URL: https://github.com/apache/hudi/pull/19476#discussion_r3710141533
##########
hudi-aws/src/main/java/org/apache/hudi/aws/metrics/cloudwatch/CloudWatchReporter.java:
##########
@@ -276,8 +279,18 @@ private void stageMetricDatum(String metricName,
long timestampMilliSec,
List<MetricDatum> metricData) {
String[] metricNameParts = metricName.split("\\.", 2);
Review Comment:
Thank you — this is in the description now, in a section explaining why the
fix is reporter-side when the two prior fixes were not. Your `grep` for
`split(` confirming this is the only reporter deriving a dimension from the
metric name is the part that makes the case: the guard does not set a precedent
other reporters would have to follow, which was the objection I was most
worried about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
