hudi-agent commented on code in PR #19509:
URL: https://github.com/apache/hudi/pull/19509#discussion_r3710592079
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/NonSortPartitioner.java:
##########
@@ -47,6 +48,18 @@ public NonSortPartitioner() {
this(false);
}
+ /**
Review Comment:
🤖 nit: the same Javadoc block ("Constructor taking the write config, so this
partitioner can also be named through…") is copy-pasted verbatim across six or
so constructors. Could you shorten these to a one-liner like `// Required for
reflection-based instantiation via
BULKINSERT_USER_DEFINED_PARTITIONER_CLASS_NAME` and leave the full rationale in
the `BulkInsertPartitioner.isTablePartitioned` Javadoc (or a single shared
location), so there's only one place to update if the explanation ever changes?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
