rangareddy commented on code in PR #19490:
URL: https://github.com/apache/hudi/pull/19490#discussion_r3712380304
##########
packaging/hudi-presto-bundle/pom.xml:
##########
@@ -210,6 +205,20 @@
<version>${project.version}</version>
</dependency>
+ <!-- Jackson 1.x. Shaded via the org.codehaus.jackson:* include below and
previously reached only
+ through hudi-hadoop-mr-bundle's published POM; declared directly so
this bundle's shade inputs come
+ from libraries rather than from another bundle. compile scope because
the classes are shaded in. -->
Review Comment:
Checked, and no edit is needed after all:
`dependencies/hudi-presto-bundle.txt` lists neither jackson-asl (removed by
#6893 in the same commit you cite) nor `hudi-hadoop-mr-bundle`, so this
revision — which only deletes things — leaves it no more wrong than it was.
Since the earlier revision would have added two direct compile dependencies,
your point was correct against that version.
I noted in the PR body that the file is independently stale (10 HBase
entries although HBase went in #12964) and that `scripts/dependency.sh` is
referenced by no workflow, so a reader is not left thinking it is
authoritative. Regenerating it is not something I want to fold into a two-line
deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
