Copilot commented on code in PR #19423: URL: https://github.com/apache/hudi/pull/19423#discussion_r3716034550
########## hudi-notebooks/README.md: ########## @@ -79,6 +79,40 @@ This project provides a ready-to-use Docker Compose environment for running Apac - Spark, Hive, and Hudi configs are in `conf/` and automatically copied into containers. - S3 access keys and endpoints are set for MinIO and referenced in Spark/Hive configs. +### Using another S3-compatible object store + +Hudi reads and writes through the Hadoop S3A connector, so the same `fs.s3a.*` +settings work against any S3-compatible object store: Amazon S3, or a compatible +provider such as Backblaze B2, Cloudflare R2, or MinIO. This demo points +`fs.s3a.endpoint` at the bundled MinIO service; to target a different store, +edit `conf/hadoop/core-site.xml` (and the matching Spark/Hive configs) with that +provider's endpoint and credentials: + +```xml +<property> + <name>fs.s3a.endpoint</name> + <!-- Amazon S3: https://s3.<region>.amazonaws.com + any other provider: its S3 endpoint URL --> + <value>https://<s3-endpoint></value> +</property> Review Comment: The placeholder `<s3-endpoint>` in the `<value>` element is not valid XML (it will be interpreted as a nested tag if copied into `core-site.xml`). Consider using a plain placeholder string instead so the snippet can be copy/pasted safely. This issue also appears in the following locations of the same file: - line 100 - line 104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
