wombatu-kun commented on code in PR #19514:
URL: https://github.com/apache/hudi/pull/19514#discussion_r3717450269
##########
.asf.yaml:
##########
@@ -47,75 +47,18 @@ github:
required_status_checks:
strict: false
contexts:
+ # The CI matrix in .github/workflows/bot.yml was cut down to unblock
PRs after ASF
+ # infra disabled GitHub Actions on this repository over its runner
usage. Listing
+ # the per-job contexts here is what made every matrix change a
two-sided edit, so
+ # the test jobs are no longer required individually; reviewers gate
on the checks
+ # the PR shows. `validate-ci-baseline` is a new context that only
the reduced
+ # matrix produces, so a PR that collected its green checks before
the trim cannot
+ # merge on them: branch protection holds it until CI runs again.
+ - validate-ci-baseline
Review Comment:
`validate-ci-baseline` has no `needs:`, so with every test context dropped
and `allow_auto_merge` still enabled in this file, a PR with auto-merge on can
land the moment the five cheap checks report, whatever the test jobs and Azure
did. Is that acceptable for the interim, or should the baseline job depend on
the surviving test jobs (with `if: always()` plus an explicit `needs.*.result`
check) so one stable context still gates on them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
