voonhous commented on code in PR #19217: URL: https://github.com/apache/hudi/pull/19217#discussion_r3718082385
########## .github/workflows/hudi_trino_e2e.yml: ########## @@ -0,0 +1,171 @@ +name: Hudi Trino E2E + +on: + push: + branches: + - master + - 'release-*' + paths: + # docker/demo/** is deliberately broad: the ITs drive several demo fixture + # scripts (sparksql-*.commands, setup_demo_container.sh), so any demo edit + # must re-run this pipeline. + - 'hudi-trino/**' + - 'docker/trino/**' + - 'docker/compose/docker-compose_hadoop340_hive2310_spark402*' + - 'docker/demo/**' + - 'hudi-integ-test/src/test/java/org/apache/hudi/integ2/**' + - '.github/workflows/hudi_trino_e2e.yml' + pull_request: + branches: + - master + - 'release-*' + paths: + - 'hudi-trino/**' + - 'docker/trino/**' + - 'docker/compose/docker-compose_hadoop340_hive2310_spark402*' Review Comment: Good catch -- `hadoop.env` is copied into the generated compose dir and all nine services in the spark402 pair load it, so it is as load-bearing as the YAMLs. Added `docker/compose/hadoop.env` to both the `push` and `pull_request` lists, with a comment saying why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
