rangareddy commented on PR #19491:
URL: https://github.com/apache/hudi/pull/19491#issuecomment-5188388427
Correcting the record on this PR rather than leaving a stale claim in the
body.
I had "CI passes on my PR" checked. That is not supportable:
`validate-bundles` ran on this PR exactly once, on the revision *before* the
selector fix, and that run is what found the bug. ASF Infra then disabled
Actions on the repo over runner-time usage (#19514), so since the fix only the
cheap gates have reported — the green checks here are those gates, not the new
assertion. The box is now unchecked with the reason.
Standing in for the missing run, I exercised the script locally against a
bundle built from current master, on every path plus a negative test:
```
main artifact -> exit 0 3/3 required classes, 109
org/apache/hudi/hadoop/** (floor 100)
-sources.jar -> exit 1 refused by name, message says
what to pass
missing jar path / no argument -> exit 1
same jar, those entries zip -d out -> exit 1
"HoodieParquetInputFormat.class is missing ... An artifactSet
include probably matched no
artifact"
```
The last one is the #19433 shape reproduced on purpose, so the gate is not
vacuous. What is still unverified outside CI is only the workflow wiring —
which is exactly what bit last time, so I would rather say so than imply
otherwise.
One interaction worth flagging for #19514, since it trims this same job:
afterwards `validate-bundles` keeps only the `scala-2.13` matrix entry, and
that branch of `Build Project` builds a `-pl`-limited set that does not include
`packaging/hudi-presto-bundle`. This step is unaffected — it builds the bundle
itself, deliberately without `-am` so the bundle dependencies resolve from the
repository rather than the reactor — but it will need a rebase for the textual
conflict in `bot.yml`. Happy to rebase onto #19514 whenever that lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
