pengzhiwei2018 edited a comment on pull request #2651: URL: https://github.com/apache/hudi/pull/2651#issuecomment-808036420
> LGTM now. I mostly have just minor comments now which you can address. > > Can you run these unit tests you added once with `-Pspark3` to make sure this is running seamlessly for Spark 3 ? The travis tests right now don't run the tests with Spark 3. Hi @umehrot2 , I have address the comments you have mentioned above. And also have build the project with -Pspark3. There is a method parameter change for `PartitioningUtils.parsePartition` in spark3. So I add an `SparkParsePartitionUtil` interface to adapter both spark2 and spark3, just like the `SparkRowSerDe` does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
