danny0405 commented on PR #19338: URL: https://github.com/apache/hudi/pull/19338#issuecomment-5211158987
A potential improvement for v1 archived timeline: The latest PR already performs a start-instant-based archive lookup: ```java metaClient.getArchivedTimeline(startInstant, false) ``` For V1, the missing improvement is to make that the actual incremental-query path, not just the candidate-discovery path. Currently: 1. `CompletionTimeQueryViewV1` loads archived instants from the requested start time. 2. `IncrementalQueryAnalyzer` discards that timeline and loads it again. A cleaner V1 design would have `IncrementalQueryAnalyzer` load the filtered archived timeline once, apply `InstantRange` directly to `HoodieInstant.requestedTime()`, and reuse that same timeline in `QueryContext`. This is valid because V1 has: ```text completion time == requested/start instant time ``` That would preserve V2-compatible range semantics while eliminating the redundant archive scan. Simply adding another start-time lookup inside `CompletionTimeQueryViewV1` would not address the concern—the PR already has that part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
