hudi-agent commented on code in PR #19552: URL: https://github.com/apache/hudi/pull/19552#discussion_r3735577342
########## website/docs/cleaning.md: ########## @@ -86,6 +86,23 @@ takes precedence over the regex. | `hoodie.clean.partition.filter.regex` | (none) | Java regex pattern; only partitions whose path matches are cleaned. | | `hoodie.clean.partition.filter.selected` | (none) | Comma-separated list of partition paths to clean; takes precedence over the regex when both are set. | +### Instant Times in Clean Metadata + +Hudi 1.x stamps every action with both a requested instant time and a completion time, and orders actions on the +timeline by completion time — see [timeline](timeline.md). The cleaner's own plan and metadata, however, record +**instant (start) times** throughout. Keep this in mind when reading them for debugging. + +| Field | Written to | Value | +|---|---|---| +| `earliestInstantToRetain.timestamp` | `HoodieCleanerPlan` (the `clean.requested` instant) | Instant time of the oldest commit this clean run retains. | +| `earliestCommitToRetain` | `HoodieCleanMetadata` (the completed `clean` instant) | Copied from the plan, so also an instant time. | +| `lastCompletedCommitTimestamp` | both | Instant time of the last completed write before the clean was planned. Despite the name, this is a start time, not a completion time. | +| `startCleanTime` | `HoodieCleanMetadata` | Instant time of the clean action itself. | + +Incremental clean planning follows the same convention: it selects the commits whose **requested** instant time falls +between the previous clean's `earliestCommitToRetain` and the current one, and scans only the partitions those commits Review Comment: 🤖 This sentence reads clearly overall, but "between the previous clean's `earliestCommitToRetain` and the current one" leaves "the current one" a little ambiguous — it could help to spell out that it means the current clean's `earliestCommitToRetain`, so readers don't have to infer the endpoint. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
