danny0405 commented on code in PR #19211:
URL: https://github.com/apache/hudi/pull/19211#discussion_r3771234001
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieSplitReaderFunction.java:
##########
@@ -91,6 +98,45 @@ protected ClosableIterator<RowData>
createRecordIterator(HoodieSourceSplit split
}
}
+ /**
+ * Wraps the raw iterator with {@link BlobMaterializingIterator} when
+ * {@link FlinkOptions#BLOB_READ_MATERIALIZE} is enabled and the required
schema contains
+ * at least one BLOB field.
+ */
+ private ClosableIterator<RowData> maybeMaterialize(ClosableIterator<RowData>
iter) {
+ if (!conf.get(FlinkOptions.BLOB_READ_MATERIALIZE)) {
Review Comment:
a little improvement: we could do the detection based on the flag and schema
on the function construction instead of per iterator/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
