danny0405 commented on code in PR #19205: URL: https://github.com/apache/hudi/pull/19205#discussion_r3773871993
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteMergeHandle.java: ########## @@ -108,6 +109,12 @@ public class HoodieWriteMergeHandle<T, I, K, O> extends HoodieAbstractMergeHandl @Setter protected HoodieReaderContext<T> readerContext; + // Read from the TABLE config, not the write config -- see the note on BaseCreateHandle. Resolved + // once rather than per record: writeToFile consults it on the preserve-metadata path, which runs + // for every record copied forward during a merge. + private final MetaFieldsMode metaFieldsMode = MetaFieldsMode.orAllIfUnknown( + hoodieTable.getMetaClient().getTableConfig().getMetaFieldsMode()); Review Comment: just give the table config the default value as `ALL` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
