yihua opened a new pull request, #19161:
URL: https://github.com/apache/hudi/pull/19161

   ### Describe the issue this Pull Request addresses
   
   Several Spark SQL stored procedures in the `hudi-spark` `command/procedures` 
package had large untested gaps. Most notably `HoodieProcedureFilterUtils` (the 
procedure filter-expression evaluator) had no test file and was ~18% covered.
   
   ### Summary and Changelog
   
   - New `TestHoodieProcedureFilterUtils`: direct tests for the 
filter-expression evaluator (expression parsing, the function-resolution table, 
numeric type coercion, complex-type conversion, validation and error paths), 
including a case documenting that time-zone-aware timestamp functions cannot be 
evaluated without a resolved time zone.
   - New `TestValidateHoodieSyncProcedure`: exercises `sync_validate`'s 
timeline comparison and catch-up-commit computation via a mode that bypasses 
the Hive/JDBC record count.
   - Extends existing suites for `copy_to_temp_view` (incremental / 
read_optimized / as_of_instant), `show_logfile_records` (merge + filter), 
`repair_clustering_plan` (validate_delete, unsupported op, allow_empty_plan 
guard), and `show_clean_plans` (input validation).
   
   All tests assert output rows, state changes, or exceptions; no 
assertion-free runs and no timing-based waits. `hive_sync` is intentionally 
left uncovered: its uncovered lines require a live/embedded Hive metastore and 
would be flaky in a unit test. (Coverage for `export_instants`, plus a product 
fix it surfaced, is in #19172.)
   
   ### Impact
   
   Test-only change. No production code is modified; no user-facing behavior 
change.
   
   ### Risk Level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to