danny0405 commented on code in PR #19205:
URL: https://github.com/apache/hudi/pull/19205#discussion_r3782724570
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetWriter.java:
##########
@@ -54,12 +55,12 @@ public HoodieSparkParquetWriter(StoragePath file,
HoodieRowParquetConfig parquetConfig,
String instantTime,
TaskContextSupplier taskContextSupplier,
- boolean populateMetaFields) throws
IOException {
+ MetaFieldsMode metaFieldsMode) throws
IOException {
super(file, parquetConfig);
this.writeSupport = parquetConfig.getWriteSupport();
this.fileName = UTF8String.fromString(file.getName());
this.instantTime = UTF8String.fromString(instantTime);
- this.populateMetaFields = populateMetaFields;
+ this.metaFieldsMode = metaFieldsMode == null ? MetaFieldsMode.NONE :
metaFieldsMode;
Review Comment:
the write handles deem null as `ALL` through `MetaFieldsMode.orAllIfUnknown`
while here the null equals `NONE`, is this even consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
