voonhous commented on code in PR #19642:
URL: https://github.com/apache/hudi/pull/19642#discussion_r3793862741
##########
hudi-trino/src/test/java/io/trino/plugin/hudi/HudiQueryRunner.java:
##########
@@ -56,14 +56,14 @@ public static Builder builder()
return new Builder("local:///");
}
- public static Builder builder(Hive3MinioDataLake hiveMinioDataLake)
+ public static Builder builder(Hive3FlociDataLake hiveFlociDataLake)
{
- return new Builder("s3://" + hiveMinioDataLake.getBucketName() + "/")
- .addConnectorProperty("fs.native-s3.enabled", "true")
- .addConnectorProperty("s3.aws-access-key", MINIO_ROOT_USER)
- .addConnectorProperty("s3.aws-secret-key", MINIO_ROOT_PASSWORD)
- .addConnectorProperty("s3.region", MINIO_REGION)
- .addConnectorProperty("s3.endpoint",
hiveMinioDataLake.getMinio().getMinioAddress())
+ return new Builder("s3://" + hiveFlociDataLake.getBucketName() + "/")
+ .addConnectorProperty("fs.s3.enabled", "true")
Review Comment:
Fixed in 91d2d4c88c8f: added the BOM-managed test-scope
`trino-blob-cache-memory`/`-alluxio` deps and loaded the managers the way
iceberg does (`MemoryBlobCachePlugin` unconditionally in `HudiQueryRunner`,
alluxio via `withBlobCache` + a `getBlobCacheProperties` hook in the smoke
base), wrapped the raw `String`s in `Slices.utf8Slice`, and moved the
memory-cache expectations to the `BlobCache.get` span (the test's span filter
now includes `BlobCache.*`). All five affected classes pass locally (95 tests).
The trino-m2 cache key was bumped to v2 because the failed run had already
saved a cache without the memory artifact.
##########
release/release_guide.md:
##########
@@ -429,6 +429,23 @@ Set up a few environment variables to simplify Maven
commands that follow. This
and `./scripts/release/deploy_staging_jars_java25.sh 2>&1 | tee -a
"/tmp/${RELEASE_VERSION}-${RC_NUM}.deploy3.log"`.
This step must run after the Java 11 step in 9.4.1, which installs
the upstream Hudi modules that hudi-trino
resolves from the local m2 (the script does not pass `-am` because
Lombok cannot run on JDK 25).
+ 4. hudi-trino Trino pin-back, to be done on the release branch before
9.4.3. On master hudi-trino tracks
Review Comment:
Moved in 00c42eebfa51 to its own subsection under "Cut a release branch"
(before "Verify that a Release Build Works"), with an explicit warning that the
pin-back must precede source-release generation; the deploy step now just
points there and the contradictory "before 9.4.3" wording is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
