hudi-agent commented on code in PR #18252:
URL: https://github.com/apache/hudi/pull/18252#discussion_r3795447012
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/CloudObjectsSelectorCommon.java:
##########
@@ -117,35 +127,94 @@ public CloudObjectsSelectorCommon(TypedProperties
properties) {
* @param storageUrlSchemePrefix Eg: s3:// or gs://. The
storage-provider-specific prefix to use within the URL.
* @param storageConf storage configuration.
* @param checkIfExists check if each file exists, before adding
it to the returned list
- * @return
+ * @param existsCheckParallelism number of threads per task for the
existence checks (getObjectMetadata validates it is >= 1); 1 checks sequentially
Review Comment:
🤖 nit: the parenthetical `(getObjectMetadata validates it is >= 1)` could
mislead a caller who invokes `getCloudObjectMetadataPerPartition` directly —
they'd pass 0 expecting it to be caught, but it won't be. Could you either drop
the note, or move the `ValidationUtils.checkArgument` call into this method so
the contract is actually enforced here?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
