voonhous commented on PR #18814:
URL: https://github.com/apache/hudi/pull/18814#issuecomment-5316016064
Follow-up on my last comment: I pulled the `InProcessLockProvider` change
back out (`7b6822c`) and the PR is mergeable again.
Two reasons. It is a distinct bug in a distinct provider -- in-process map,
no rollout implications -- so it belongs in its own PR rather than riding along
with this one. And it did not actually apply: master's package reorg (#19193,
`3cc8fd128b40`) moved the real class to `org.apache.hudi.core.transaction.lock`
and left a `@Deprecated @CompatAlias` shim behind at the old path, so the edit
both conflicted with master and would have landed on the shim.
The bug is still real and worth a follow-up ticket:
`core/transaction/lock/InProcessLockProvider.java:79` keys
`LOCK_INSTANCE_PER_BASEPATH` on the raw base path. Whoever picks it up should
know that `HoodieTimeGeneratorConfig.defaultConfig("")` passes an empty base
path through `InProcessTimeGenerator`, which the canonicalizer rejects, so it
needs a fallback for degenerate paths.
This also re-confirms the rebase point from my earlier comment -- the branch
is far enough behind master that files under it have since moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
