deepakpanda93 commented on issue #15236: URL: https://github.com/apache/hudi/issues/15236#issuecomment-5324964801
This issue was reviewed as part of the JIRA-migrated backlog triage and is being closed - the premise does not hold. The ask is to *"refactor the common methods"* of `SnowflakeSyncTool` and `BigQuerySyncTool` into a shared abstract class. But `SnowflakeSyncTool` does not exist as code: searching current master (`989badc3952e`) for it returns exactly one hit, `rfc/rfc-41/rfc-41.md`, i.e. it appears only as a proposal in an RFC and was never implemented. `BigQuerySyncTool` is real (`hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java`), but it is the only one of the pair - so there is no duplication between the two to extract. No commit or PR carries HUDI-4254, and the JIRA last moved 2023-03-10. Closing. If a Snowflake sync tool is ever implemented and ends up duplicating the BigQuery one, that is the point at which a shared abstraction is worth filing for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
